Messages in this thread | | | Date | Wed, 4 May 2005 15:31:29 +0200 | From | Andrea Arcangeli <> | Subject | Re: avoid infinite loop in x86_64 interrupt return |
| |
On Wed, May 04, 2005 at 11:00:32AM +0200, Rafael J. Wysocki wrote: > You also need to add two missing clis. Please have a look at the attached > patch from Andi.
Those two clis seems unrelated, so I don't see why I should mix them in the same patch. I couldn't trigger the other problems, only the one with rdi corruption.
Note that those clis seems superflous, cli is only needed before swapgs, so adding cli before swapgs in retint_swapgs sounds a better idea than to keep irq off for a longer time for no apparent good reason. But I've no real idea why those cli are needed so I guess I must be missing something. there's no commentary attached to your patch that can exlain why the cli are needed _way_ before calling swapgs. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |