[lkml]   [2005]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ds1337 3/3

Hi Ladislav, hi all,

> Chip is searched by bus number rather than its own proprietary id.

Yes, I think it makes much more sense (especially since the proprietary
id was not known by anyone outside of the ds1337 driver).

I think I understand that ds1337_do_command() will be called from some
other kernel driver. Why isn't it exported then? I'd expect:
next to the end of the ds1337 driver. Maybe it would also make sense to
have a ds1337.h header file declaring this function?

Additionally, I would welcome an additional patch documenting the fact
that the ds1337 driver will work fine with the Dallas DS1339 real-time
clock chip.

Jean Delvare
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-05-04 12:17    [W:0.165 / U:1.604 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site