lkml.org 
[lkml]   [2005]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] ds1337 3/3
    From

    Hi Ladislav, hi all,

    > Chip is searched by bus number rather than its own proprietary id.

    Yes, I think it makes much more sense (especially since the proprietary
    id was not known by anyone outside of the ds1337 driver).

    I think I understand that ds1337_do_command() will be called from some
    other kernel driver. Why isn't it exported then? I'd expect:
    EXPORT_SYMBOL(ds1337_do_command);
    next to the end of the ds1337 driver. Maybe it would also make sense to
    have a ds1337.h header file declaring this function?

    Additionally, I would welcome an additional patch documenting the fact
    that the ds1337 driver will work fine with the Dallas DS1339 real-time
    clock chip.

    Thanks,
    --
    Jean Delvare
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-05-04 12:17    [W:0.021 / U:88.800 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site