lkml.org 
[lkml]   [2005]   [May]   [30]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    DateMon, 30 May 2005 15:32:02 +0900
    FromYoshinori Sato <>
    SubjectRe: [patch 1/1] ptrace_h8300: condition bugfix
    At Sun, 29 May 2005 01:16:28 +0200,
    domen@coderock.org wrote:
    > 
    > From: Domen Puncer <domen@coderock.org>
    > 
    > 
    > Assignment doesn't make much sense here as condition would always be
    > true.
    > 
    
    Thanks.
    I applied it.
    
    Signed-off-by: Domen Puncer <domen@coderock.org>
    Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
    
    ---
     ptrace_h8300h.c |    4 ++--
     1 files changed, 2 insertions(+), 2 deletions(-)
    Index: quilt/arch/h8300/platform/h8300h/ptrace_h8300h.c
    ===================================================================
    --- quilt.orig/arch/h8300/platform/h8300h/ptrace_h8300h.c
    +++ quilt/arch/h8300/platform/h8300h/ptrace_h8300h.c
    @@ -245,12 +245,12 @@ static unsigned short *getnextpc(struct 
     						addr = h8300_get_reg(child, regno-1+PT_ER1);
     					return (unsigned short *)addr;
     				case relb:
    -					if ((inst = 0x55) || isbranch(child,inst & 0x0f))
    +					if (inst == 0x55 || isbranch(child,inst & 0x0f))
     						pc = (unsigned short *)((unsigned long)pc +
     								       ((signed char)(*fetch_p)));
     					return pc+1; /* skip myself */
     				case relw:
    -					if ((inst = 0x5c) || isbranch(child,(*fetch_p & 0xf0) >> 4))
    +					if (inst == 0x5c || isbranch(child,(*fetch_p & 0xf0) >> 4))
     						pc = (unsigned short *)((unsigned long)pc +
     								       ((signed short)(*(pc+1))));
     					return pc+2; /* skip myself */
    --
    
    -- 
    Yoshinori Sato
    <ysato@users.sourceforge.jp>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2005-05-30 08:36    [from the cache]
    ©2003-2008