Messages in this thread | | | Date | Fri, 27 May 2005 10:35:11 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] SATA NCQ support |
| |
On Fri, May 27 2005, Jeff Garzik wrote: > Jens Axboe wrote: > >On Fri, May 27 2005, Jeff Garzik wrote: > >>I just noticed a bug -- When ata_scsi_qc_new() fails, the code should > >>complete the command with queue-full, but does not. > >> > >> qc = ata_scsi_qc_new(ap, dev, cmd, done); > >> if (!qc) > >> return; > > > > > >Indeed, looks like an old bug. > > Yep. If you are knocking around in that area, would you mind killing it > for me? :)
Actually, I didn't look far enough up - ata_scsi_qc_new() already completes the command with QUEUE_FULL if ata_qc_new_init() fails. So there's no bug, but perhaps it would be cleaner to move it to ata_scsi_translate instead?
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |