Messages in this thread | | | Subject | Re: [PATCH] fix ide-scsi EH locking | From | Alan Cox <> | Date | Sat, 28 May 2005 00:09:02 +0100 |
| |
On Gwe, 2005-05-27 at 22:19, Jeff Garzik wrote: > Patch untested, but at least the code isn't obviously wrong now...
The abort code check of cmd->serial_number is the only thing I can see that needs care and that looks safe by the time we hit eh_abort because the mid level has quiesced the request queue.
eh_reset is whacking on requests but they are the IDE layer requests so I suspect you want to simply drop the scsi locks for the eh functions much earlier and use spin_lock_irqsave/restore on the ide lock ?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |