Messages in this thread | | | Date | Fri, 27 May 2005 16:58:50 +0200 | From | Jens Axboe <> | Subject | Re: Resend: PATCH: Stop 2.6.12rc rmmod from being able to destroy CD hardware |
| |
On Fri, May 27 2005, Linus Torvalds wrote: > > > On Fri, 27 May 2005, Alan Cox wrote: > > > > The simple fix is attached, making the driver start from ~0 and mask > > bits the other direction would longer term be safer. > > As per Bartlomiej, I've not applied this, since the "don't do it unless > you've written to it" fix from Jens went in. I assume CD-RW's know how to > cache flush.. > > That said, it does sound like the capabilities bitmap should be changed > around to be the other way (either by starting at ~0, or, if the changes > aren't too invasive, just change the semantics of it to be the sane way > around ("drive can do this" rather than "drive can _not_ do this").
They should, it's always annoyed me because it's counter intuitive.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |