lkml.org 
[lkml]   [2005]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.12-rc1-mm3
Hi,

On 26/05/2005 4:20 p.m., Andrew Morton wrote:
> Reuben Farrelly <reuben-lkml@reub.net> wrote:
>
>>>Reuben, could you please try the patch below? Thanks!
>>>
>>>Russell, could you please tell me if ldisc->write_wakeup (tty_wakwup) and
>>>ldisc->read are allowed to be called from an IRQ context? IOW I wonder if
>>>I can use spil_lock_bh instead of spil_lock_irqsave to protect serport
>>>flags.
>>>
>>>--
>>>Dmitry
>>>
>>> serport.c | 98
>>>+++++++++++++++++++++++++++++++++++++++++++-------------------
>>> 1 files changed, 68 insertions(+), 30 deletions(-)
>>>
>>>Index: dtor/drivers/input/serio/serport.c
>>>===================================================================
>>>--- dtor.orig/drivers/input/serio/serport.c
>>>+++ dtor/drivers/input/serio/serport.c
>>>@@ -27,11 +27,15 @@ MODULE_LICENSE("GPL");
>>> MODULE_ALIAS_LDISC(N_MOUSE);
>>
>>
>>I've done some testing this afternoon and it seems that this patch
>>fixes the problem in -mm4. I don't even have a serial
>>mouse/keyboard, but do have a serial PCI card onboard. The box has a
>>USB connection to a Belkin KVM instead of directly attached input devices.
>>
>>I also note that it is occurring on kernel-smp-2.6.11-1.1219_FC4 - so
>>it is probably a problem in mainline as well as -mm.
>
>
> Can you please confirm that the above fix is present in 2.6.12-rc5 and that
> 2.6.12-rc5 is working OK?

The fix is definitely in -rc5 (thanks), and without doubt fixed the problem I
was seeing (thanks Dmitry). I haven't tested on a vanilla 2.6.12-rc5, but I
can confirm that 2.6.12-rc4-mm* releases have not had the problem. The patch
was of course in -rc4-mm* and possibly earlier?

> >>Now I'm crashing a bit further through the shutdown, here's the stacktrace:
>
>
> Is this still occurring in either 2.6.12-rc5 or 2.6.12-rc5-mm1?

2.6.12-rc4-mm* releases have been stable, I haven't seen any oopses for a few
weeks now.

If confirmation is required in -rc5 then I'm happy to attempt this, but I
don't think it's at all likely given I haven't seen any oopses at all since
that patch was included in -mm, and the patch is now in upstream.

Btw, I didn't see a lkml-announce message about -rc5-mm1 being released :( No
big deal really...

reuben
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-26 12:14    [W:0.255 / U:0.220 seconds]
©2003-2011 Jasper Spaans. Advertise on this site