lkml.org 
[lkml]   [2005]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch 1/4] Kprobes support for IA64
    Date
    On Mon, 23 May 2005 08:39:07 -0700, 
    Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> wrote:
    >
    >This patch adds the kdebug die notification mechanism needed by Kprobes.
    > case 0: /* unknown error (used by GCC for __builtin_abort()) */
    >+ if (notify_die(DIE_BREAK, "kprobe", regs, break_num, TRAP_BRKPT, SIGTRAP)
    >+ == NOTIFY_STOP) {
    >+ return;
    >+ }
    > die_if_kernel("bugcheck!", regs, break_num);
    > sig = SIGILL; code = ILL_ILLOPC;
    > break;

    Nit pick. Any break instruction in a B slot will set break_num 0, so
    you cannot tell if the break was inserted by kprobe or by another
    debugger. Setting the string to "kprobe" is misleading here, change it
    to "break 0".

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-05-24 07:47    [W:0.019 / U:2.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site