lkml.org 
[lkml]   [2005]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/4] CPU Hotplug support for X86_64
On Tue, May 24, 2005 at 02:15:42PM +0200, Andi Kleen wrote:
> On Tue, May 24, 2005 at 01:11:14AM -0700, Ashok Raj wrote:
> > * RED-PEN audit/test this more. I bet there is more state messed up here.
> > */
> > -static __cpuinit void disable_smp(void)
> > +static __init void disable_smp(void)
>
> Why all these cpuinit->init changes? I think they should stay __cpuinit
>
> The other way round looks ok.

disable_smp() is called only in smp_prepare_cpus() which is not required
for hotplug. Its currently only required only for startup, and not later.

I changed the ones from __cpuinit to __init, just in functions marked
with paranoia... i think it can stay cpuinit, unless there is another reason
i didnt catch.

>
> -Andi

--
Cheers,
Ashok Raj
- Open Source Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-24 18:02    [W:0.118 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site