Messages in this thread | | | Date | Tue, 24 May 2005 15:56:36 +0100 | From | Christoph Hellwig <> | Subject | Re: [patch] Voluntary Kernel Preemption, 2.6.12-rc4-mm2 |
| |
On Tue, May 24, 2005 at 03:21:05PM +0200, Ingo Molnar wrote: > > this patch (ontop of the current -mm scheduler patchset plus the > previous 2 patches from me) adds a new preemption model: 'Voluntary > Kernel Preemption'. The 3 models can be selected from a new menu: > > (X) No Forced Preemption (Server) > ( ) Voluntary Kernel Preemption (Desktop) > ( ) Preemptible Kernel (Low-Latency Desktop) > > we still default to the stock (Server) preemption model. > > Voluntary preemption works by adding a cond_resched() > (reschedule-if-needed) call to every might_sleep() check.
I still disagree with this one violently. If you want a cond_resched() add it where nessecary, but don't hide it behind might_sleep - there could be quite a lot might_sleeps in common codepathes and they should stay purely a debug aid.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |