Messages in this thread | | | Date | Sun, 22 May 2005 08:50:26 +0200 | From | Jean Delvare <> | Subject | Re: [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks |
| |
Hi Dmitry,
> I really think that as far as I2C subsystem goes instead of creating > arrays of attributes we should move in direction of drivers > registering individual sensor class devices. So for example it87 would > register 3 fans, 3 temp, sensors and 8 voltage sensors...
First, it's a matter of hardware monitoring drivers, not i2c subsystem (both are tightly binded at the moment but I'd like this to change).
Second, not all devices have the same attributes for a temperature, fan or voltage channel. Sure there are commonly found feature sets, but some channels will lack some feature (e.g. it87's in8 has no min and max limits), other chips will provide additional features (extra limits or enhanced configurability). So I don't think you can have all devices (and thus all drivers) fit into a single sensor class.
But of course I can be convinced your approach is better, with patches. I don't know classes that well myself.
Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |