Messages in this thread | | | Date | Mon, 2 May 2005 01:48:55 -0700 | From | Joel Becker <> | Subject | Re: [PATCH] hangcheck-timer: Update to 0.9.0. |
| |
On Sun, May 01, 2005 at 01:45:37PM -0400, Arjan van de Ven wrote: > > + > > +#if defined(CONFIG_X86) || defined(CONFIG_X86_64) > > +# define HAVE_MONOTONIC > > +# define TIMER_FREQ 1000000000ULL > > this looks wrong! > > does this work with HZ=100 ? > also there is a TSC config option which you want to use most likely > instead of CONFIG_X86 (and x86-64 has CONFIG_X86 defined too)
It is right, though. monotonic_clock() is defined as returning nanoseconds, not a value based on HZ. It's supported on x86 and x86-64, hence using CONFIG_X86 to check. Someday, John will get it implemented for the other platforms, and we'll have less mess in hangcheck-timer.c. He already thinks that he should have the prototype in timer.h or so (so I don't have to extern declare it), but he hasn't gotten around to it yet.
Joel
--
Life's Little Instruction Book #30
"Never buy a house without a fireplace."
Joel Becker Senior Member of Technical Staff Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |