Messages in this thread |  | | | Date | Thu, 19 May 2005 11:05:31 +0400 | | From | Oleg Nesterov <> | | Subject | Re: [PATCH] Optimize sys_times for a single thread process |
| |
Christoph Lameter wrote: > > On Wed, 18 May 2005, Oleg Nesterov wrote: > > > Christoph Lameter wrote: > > > > > > +#ifdef CONFIG_SMP > > > + if (current == next_thread(current)) { > > > + /* > > > + * Single thread case without the use of any locks. > > > > A nitpick, but wouldn't be it clearer to to use > > thread_group_empty(current)? > > The thread ist needs to contain only one element which is current. > thread_group_empty checks for no threads.
I think that thread_group_empty() means that there are no *other* threads in the thread group, that means that we have only one thread.
In any case (p == next_thread(p)) == thread_group_empty(p).
But it is a very minor issue indeed, let's forget it.
Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |