![]() | |||||||||||||
Messages in this thread |
On Wednesday 18 May 2005 18:33, Mark Fasheh wrote: > http://oss.oracle.com/projects/ocfs2/dist/files/patches/2.6.12-rc4/broken-o >ut/06_dlm.patch A distributed lock manager built with the cluster file > system use case in mind. The OCFS2 dlm exposes a VMS style API, though > things have been simplified internally. The only lock levels implemented > currently are NLMODE, PRMODE and EXMODE. + if (recovery && + (!dlm_is_recovery_lock(name, strlen(name)) || convert) ) { + goto error; + } Zero terminated strings for lock names is bad taste. It generates a bunch of useless strlen executions and you force an ascii namespace for no apparent reason. Add a 9th parameter, namelen, to the lock call maybe? Regards, Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-05-19 08:29 [from the cache] ©2003-2008 | |||||||||||||