[lkml]   [2005]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks
    On 5/19/05, Jean Delvare <> wrote:
    > I finally gave a try to your patches, including the one for it87 which I
    > used for testing. It all works like a charm, pretty impressive
    > considering the overall complexity of the change. Congratulations :)

    I'm impressed too ;), and very happy to finally have confirmation it
    works as planned without blowing up anything.

    > I'd like to add that the technical solution you came up with pleases me
    > much (which may or may not be relevant).

    Well I guess a happy Jean doesn't hurt! I really can't accept full
    credit for this though, I think the end solution was a good mix of
    ideas/comments from a range of people especially Greg, Russell and

    I like the idea of aggregating the related sensor attributes into
    arrays, I did things the same way in bmcsensors but of course that was
    all dynamic, and would just use more memory if we tried to do that
    here. As Greg points out there is probably a nicer way to create the
    arrays and register the attributes, but the basic idea has merit I
    think, and if we can standardize a method across all the sensors then
    its even better.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-05-19 23:19    [W:0.023 / U:33.060 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site