Messages in this thread | | | Subject | Re: [PATCH] fix race in mark_mounts_for_expiry() | From | Miklos Szeredi <> | Date | Wed, 18 May 2005 13:14:43 +0200 |
| |
> > > > There's still the problem of cmpxchg meddling in the internals of an > > atomic_t. Is that OK? Will that work on all archs? > > Probably. It might be worth defining an atomic_cmpxchg() op to formalise it > though: > > int atomic_cmpxchg(atomic_t *p, int old, int new); > > The main reason for this is that atomic_t is mostly a 32-bit value, I think, > and cmpxchg() may sometimes enforce a 64-bit value. > > It can be made to work on PPC, PPC64, x86, x86_64, frv. I imagine it'll work > on MIPS, sparc and alpha too without too much trouble. Dunno about the rest.
Any takers?
I'd rather not do this, if I don't have to :)
Do you think my original fix is wrong, or is this just cosmetics?
Thanks, Miklos - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |