lkml.org 
[lkml]   [2005]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Illegal use of reserved word in system.h
On Thu, May 19, 2005 at 01:42:28AM +0200, Andi Kleen wrote:
> "Gilbert, John" <JGG@dolby.com> writes:
> >
> > I think it's been in there a while, but only really blows up when built
> >
> > under recent kernels.
> >
> > I agree, it's probably not the right way to go.
>
> It's quite dangerous. I suppose it uses this for atomic.h, but it
> means that a mysql compiled under a uniprocessor kernel (or rather
> with a autoconf.h of a uniprocessor kernel, it can even be SMP) will
> have subtle races when run on a SMP system because the atomic
> instructions will miss lock prefixes. Sounds like an open
> deathtrap to me.
>...

They work around this issue by doing

#ifndef CONFIG_SMP
#define CONFIG_SMP
#endif

> -Andi

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-19 02:03    [W:0.090 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site