lkml.org 
[lkml]   [2005]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix error handling in bus_add_device
    On Thu, May 12, 2005 at 04:19:24PM +0200, Hannes Reinecke wrote:
    > Hi Greg,
    >
    > this patch fixes the error handling in bus_add_device() and
    > device_attach(). Previously it was 'interesting'.
    > And totally confusing to boot.

    I agree, that's why it has been rewritten in the -mm tree :)

    Anyway, your patch doesn't take into account that device_attach()'s
    return value is tested in the bus_rescan_devices_helper(), so if you
    change the return value, that also needs to be changed.

    But even in the -mm tree, the bus_add_devices() function has not had the
    error handling added to it that you provided, is there any devices that
    you are seeing that need this?

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-05-18 07:55    [W:0.020 / U:87.664 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site