lkml.org 
[lkml]   [2005]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC/PATCH 2/5] mm/fs: execute in place (V2)
    On Wed, May 18, 2005 at 04:56:42PM +0200, Carsten Otte wrote:
    > I do plainly agree that this would make the code more readable here.
    > But it has a significant downside:
    > Once you have a different set of file operations for either case, you
    > also need to have a different file_operations struct in each individual
    > filesystem using this. Also, this moves the check "do we have xip today?"
    > from here to the filesystem that needs to decide which file operations
    > struct to use.
    > Looking forward, there may be multiple filesystems using this which
    > leads to duplicating the need for this check.

    I don't think that's much of a problem. The filesystem has a new file_operations
    instance and decided at read_inode time which one to use. You already have different
    address_space operations and a different truncate anyway.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-05-18 17:38    [W:0.019 / U:30.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site