[lkml]   [2005]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 4/8] ppc64: add BPA platform type
    On Dinsdag 17 Mai 2005 09:01, Paul Mackerras wrote:
    > Arnd Bergmann writes:
    > > This adds the basic support for running on BPA machines.
    > > So far, this is only the IBM workstation, and it will
    > > not run on others without a little more generalization.
    > > +/* FIXME: consolidate this into rtas.c or similar */
    > > +static void __init pSeries_calibrate_decr(void)
    > Shouldn't this be called bpa_calibrate_decr or something similar?

    The function is identical to the one for pSeries, and I'd
    prefer to have only one copy of it with a more generic name.
    Actually, it looks like maple and perhaps pmac have a very
    similar *_calibrate_decr function, so I could perhaps
    just put this into time.c as generic_calibrate_decr().

    [ Ben, can you tell if pSeries_calibrate_decr should work on
    all G5 macs or if it can be changed to support them as well? ]

    On a similar issue, I just remembered that I wanted to
    create a rtas_time.c to hold the rtc access functions
    for pSeries and BPA. Do you think that's a good idea?

    > > -#define PV_630 0x0040
    > > -#define PV_630p 0x0041
    > > +#define PV_630 0x0040
    > > +#define PV_630p 0x0041
    > Hmmm, I don't think your patch needs to clean up the whitespace here.


    Arnd <><
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-05-17 13:39    [W:0.021 / U:9.640 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site