lkml.org 
[lkml]   [2005]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2.6.12-rc4-mm1 3/4] megaraid_sas: updating the driver
Date
>
>On Mon, 2005-05-16 at 10:06 +0200, Arjan van de Ven wrote:
>> > + spin_lock( instance->host_lock );
>> > + cmd->scmd->scsi_done( cmd->scmd );
>> > + spin_unlock( instance->host_lock );
>>
>> are you really sure you don't want to use spin_lock_irqsave() here ?
>
>Actually, don't bother with the lock at all. scsi_done() is
>designed to
>be called locklessly.
>
>James

Okay. I will remove that.

Thanks,
Sreenivas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-18 00:23    [W:0.024 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site