Messages in this thread | | | Date | Tue, 17 May 2005 10:33:17 -0700 (PDT) | From | dean gaudet <> | Subject | Re: [patch 1/7] BSD Secure Levels: printk overhaul |
| |
On Tue, 17 May 2005, Michael Halcrow wrote:
> This is the first in a series of seven patches to the BSD Secure > Levels LSM. It overhauls the printk mechanism in order to reduce the > unnecessary usage of the .text area. Thanks to Brad Spengler for the > suggestion.
it also changes the rate limiting from per message to global... so one noisy message could shut off other non-noisy messages. was that intentional?
-dean
> -#define seclvl_printk(verb, type, fmt, arg...) \ > - do { \ > - if (verbosity >= verb) { \ > - static unsigned long _prior; \ > - unsigned long _now = jiffies; \ > - if ((_now - _prior) > HZ) { \ > - printk(type "%s: %s: " fmt, \ > - MY_NAME, __FUNCTION__ , \ > - ## arg); \ > - _prior = _now; \ > - } \ > - } \ > - } while (0) > +static void seclvl_printk(int verb, const char *fmt, ...) > +{ > + va_list args; > + va_start(args, fmt); > + if (verbosity >= verb) { > + static unsigned long _prior; > + unsigned long _now = jiffies; > + if ((_now - _prior) > HZ) { > + vprintk(fmt, args); > + } > + _prior = _now; > + } > + va_end(args); > +} - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |