lkml.org 
[lkml]   [2005]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix root hole in raw device
On Tue, May 17, 2005 at 02:04:42PM +0100, Stephen C. Tweedie wrote:
> Hi,
>
> On Tue, 2005-05-17 at 05:57, Al Viro wrote:
>
> > That is not quite correct. You are passing very odd filp to ->ioctl()...
> > Old variant gave NULL, which is also not too nice, though.
>
> Which would you prefer? I guess that if there _are_ going to be
> problems, we'd be better off finding them early by passing in the NULL
> value.

For now I'd rather pass NULL. Longer term (== post 2.6.12, since There Is No
2.7(tm)) - just remove the struct file * argument of bdev ioctl and have
int flags used instead, with "opened for write" and "opened non-blocking"
passed in it. And switch the inode argument to bdev...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-17 18:58    [W:1.619 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site