lkml.org 
[lkml]   [2005]   [May]   [16]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2.6.12-rc4-mm1 3/4] megaraid_sas: updating the driver
FromArjan van de Ven <>
DateMon, 16 May 2005 10:06:16 +0200
> +> +		if (exception) {> +	> +			spin_lock( instance->host_lock );> +			cmd->scmd->scsi_done( cmd->scmd );> +			spin_unlock( instance->host_lock );
are you really sure you don't want to use spin_lock_irqsave() here ?

> +	unregister_chrdev( megasas_mgmt_majorno, "megaraid_sas_ioctl" );

I really don't like this idea of weird ioctl devices though...


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-16 10:48    [from the cache]
©2003-2008