Messages in this thread | | | Date | Fri, 13 May 2005 00:29:13 +0200 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's |
| |
On Wed, Apr 27, 2005 at 11:44:08PM +0200, Adrian Bunk wrote: > On Wed, Apr 27, 2005 at 11:38:11PM +0200, Jesper Juhl wrote: > > On Wed, 27 Apr 2005, Stefan Richter wrote: > > > > > Dan Dennedy wrote on 2005-04-20: > > > > There are technical > > > > merits for removal of the external symbols that I accept. I also accept > > > > that we have no way of maintaining any sort of stable subsystem for > > > > external projects we are not aware of or who are not communicating with > > > > us about their requirements (it goes beyond just a stable interface). > > > ... > > > > I vote to remove external symbols not used by the Linux1394.org modules > > > > or the module at http://sourceforge.net/projects/video-2-1394/ > > > > > > Nobody else posted specific requirements so far. So let's clean up the API. > > > How about this: > > <snip> > > > - Add warning comments next to obsolete EXPORT_SYMBOLs. Add warning > > > printks to obsolete functions? (If there are any.) > > > > how about just adding __deprecated to them? > > Some of these functions might have valid users (e.g. from the same > file). > > __deprecated_for_modules (already in -mm) is the right solution.
Correcting myself:
Unfortunately, this doesn't work since this also gives you a bunch of warnings for usage that doesn't use the EXPORT_SYMBOL's (e.g. if the whole ieee1394 stuff is built as a module).
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |