[lkml]   [2005]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] Re: [ANNOUNCE] hotplug-ng 002 release
    On Wed, May 11, 2005 at 01:39:13PM +1000, Rusty Russell wrote:
    > On Wed, 2005-05-11 at 03:11 +0200, Erik van Konijnenburg wrote:
    > > Here's an alternative approach that should cover these interests:
    > > - add a keyword 'blacklist' to the configuration language,
    > > that will be interpreted after alias expansion, but before
    > > searching modules.dep.
    > This makes "blacklist X" equivalent to "install X /bin/true" right? i.e
    > "ignore it".

    Except for output on --show-depends and total number of forks, yes.

    Based on comments from Greg and Christian, it would be better to apply
    blacklisting only to the result of alias expanding for kernel generated
    module maps. So:

    cat >> /etc/hotplug/blacklist.d/test <<//
    blacklist snd_rme96

    would apply to

    modprobe 'pci:v000010EEd00003FC0sv*sd*bc*sc*i*'

    but not to

    modprobe snd_rme96

    > > Advantages:
    > > - it needs a lot less code
    > > - distributions can decide whether blacklists work always,
    > > never, or only for the kernel simply by playing with which
    > > configuration file is used
    > > - my initramfs builder does not have to be special cased
    > > to know that some install directives really are blacklist
    > > directives.
    > Well, a module mentioned in hotplug's blacklist file would be a pretty
    > good candidate for exclusion from your initramfs builder. Existing
    > install commands are already trouble for initramfs building, since they
    > can do arbitrary things...

    Yep. At the moment my initramfs builder aborts on such install directives,
    because there's no correct way of handling them. Since install isn't used
    all that much and certainly not in boot-critical stuff, thats acceptable,
    but if we're going to use install for every blacklisted module,
    that's a problem.

    > How about I allow "--config=-" and hotplug can use the existing
    > blacklists and 'sed'?

    That would keep existing blacklist, which is good for Marco and
    for initramfs builders.

    However, it would be bad for hotplug-ng: one of the strong points
    is that it speeds booting by dropping loads of shell code, and
    adding sed for blacklist processing does not fit well with that.

    I'll take a stab at a patch that introduces the 'blacklist' keyword
    to see if that reduces the code enough to make it acceptable.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-05-11 12:05    [W:0.023 / U:0.316 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site