Messages in this thread | | | Date | Wed, 11 May 2005 10:06:00 -0700 | From | Greg KH <> | Subject | Re: [PATCH 2.6.12-rc4 3/3] (dynamic sysfs callbacks) device_attribute |
| |
On Wed, May 11, 2005 at 03:58:35AM -0400, Yani Ioannou wrote: > Hi, > > This patch presents as an example one possible way to use the dynamic > callbacks to clean up one of the i2c chip drivers, adm1026 (for more > information please see > http://archives.andrew.net.au/lm-sensors/msg31310.html). > > The first patch defines a new macros like DEVICE_ATTR that also sets > the attribute private data (Greg whats your opinion on defining a > separate set of macros for this v.s. rolling it into one macro?).
We should make a __ATTR macro instead, right?
> The second patch changes adm1026 to pass the sensor index/number via > the private data pointer. I can't test this patch (so you won't want > to apply this) but I'm CCing it to the adm1026 maintainer.
One patch per email please...
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |