lkml.org 
[lkml]   [2005]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Fix PCI mmap on ppc and ppc64
From
Date
On Tue, 2005-05-10 at 15:18 +0200, Andreas Schwab wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>
> > @@ -351,9 +351,12 @@
> > *offset += hose->pci_mem_offset;
> > res_bit = IORESOURCE_MEM;
> > } else {
> > - io_offset = (unsigned long)hose->io_base_virt;
> > + io_offset = (unsigned long)hose->io_base_virt - pci_io_base;
> > + printk("offset: %lx, io_base_virt: %p, pci_io_base: %lx, io_offset: %
> > lx\n",
> > + *offset, hose->io_base_virt, pci_io_base, io_offset);
> > *offset += io_offset;
> > res_bit = IORESOURCE_IO;
> > + printk(" -> offset: %lx\n", *offset);
>
> I don't think you want those debugging printks be left here.

Good point, looks like I got really sloppy on this patch. I'll send a
fix tomorrow unless andrew beats me at it as this isn't yet in any
released -mm

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-10 16:04    [W:0.038 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site