Messages in this thread | | | Date | Fri, 8 Apr 2005 15:18:02 -0700 | From | Greg KH <> | Subject | Re: [PATCH] Reduce <linux/debugfs.h> dependencies |
| |
On Mon, Mar 28, 2005 at 09:16:58AM -0800, Roland Dreier wrote: > The current <linux/debugfs.h> include file is a little fragile in that > it is not self-contained and hence may cause compile warnings or > errors depending on the files included before it, the kernel config > and the architecture. This patch makes things a little more robust by: > > - including <linux/types.h> to get definitions of u32, mode_t, and so on. > - forward declaring struct file_operations. > - including <linux/err.h> when CONFIG_DEBUG_FS is not set > > The last change is particularly useful, as a kernel developer is > likely to build with debugfs always enabled and never see the build > breakage cased if debugfs is disabled. > > Signed-off-by: Roland Dreier <roland@topspin.com>
Applied, thanks.
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |