[lkml]   [2005]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] i2c: new driver for ds1337 RTC
    On Thu, Apr 07, 2005 at 04:28:04PM +0200, Ladislav Michl wrote:
    > Here is yet another patch this time fixes only.
    > * use i2_tranfer function instead of adapter->algo->master_xfer, so
    > we have proper bus locking.
    > * BCD2BIN and BIN2BCD are proper macros to use here, see linux/bcd.h
    > * Move NULL argument checking from get/set date functions to
    > ds1337_command function, so it is only at one place. Note that other
    > drivers do not this checking at all and I think it is pointess,
    > because you have to know that you are passing struct rtc_time anyway.
    > * dev_dbg should probably print info about device driver we are
    > debugging so client->dev looks as better choice than
    > client->adapter->dev.

    Jean's point is that you should send an individual patch for each type
    of individual change. It's ok to say "patch 3 requires you to have
    applied patches 1 and 2" and so on. Please split this up better.


    greg k-h
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-04-07 23:23    [W:0.020 / U:5.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site