lkml.org 
[lkml]   [2005]   [Apr]   [5]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 05 Apr 2005 15:19:05 +0900
FromTejun Heo <>
SubjectRe: [PATCH scsi-misc-2.6 08/13] scsi: move request preps in other places into prep_fn()
  Hello, James.

James Bottomley wrote:
> On Fri, 2005-04-01 at 14:25 +0900, Tejun Heo wrote:
> 
>> Ah.. with later requeue path consolidation patches, all requests get
>>their sense buffer cleared during requeueing, which, IMHO, is more
>>logical.  Moving scsi_init_cmd_errh() should come after the patch.
>>Sorry. :-)
>>
>> I'll make another take of this patchset (maybe subset) after issues
>>are resolved.  I'll split and reorder relocation of scsi_init_cmd_errh
>>then.
> 
> 
> Thanks.  It would help me enormously if you explained what bugs you were
> fixing at the top of each patch,

  Well, I'll try harder.

 > and also only do patchsets that are
> dependent on each other (I already have your serial_numer_at_timeout and
> internal_timeout removal patches in the scsi-misc-2.6 tree).

  No problem.  Do you want me to do that now?  Or is it okay to do the 
next take after you review the request_fn rewrite patch?

  Thanks.

-- 
tejun

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-06 13:31    [W:5.419 / U:0.010 seconds]
©2003-2008 Jasper Spaans