lkml.org 
[lkml]   [2005]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 00/04] Load keyspan firmware with hotplug
    From
    On Tue, Apr 05, 2005 at 11:22:06AM +0200, Marcel Holtmann wrote:
    > I agree with Dmitry on this point. The IHEX parser should not be inside
    > firmware_class.c. What about using keyspan_ihex.[ch] for it?

    That's what I had originally, actually called firmware_ihex.ko, since
    the IHEX format parser is not in any way keyspan specific and there are
    several usb-serial converters that seem to use the same IHEX->.h trick
    which could trivially be modified to use this loader.

    But the compiled parser fairly small (< 2KB) and adding it to the
    existing module didn't effectively add any size to the firmware_class
    module since things are rounded to a page boundary anyways.

    Jan

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-06 13:31    [W:0.032 / U:3.656 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site