Messages in this thread | | | Date | Sat, 30 Apr 2005 11:10:14 +0300 (EEST) | From | Kai Makisara <> | Subject | Re: [06/07] [PATCH] SCSI tape security: require CAP_ADMIN for SG_IO etc. |
| |
On Fri, 29 Apr 2005, Greg KH wrote:
> On Sat, Apr 30, 2005 at 08:52:31AM +0300, Kai Makisara wrote: > > On Fri, 29 Apr 2005, Greg KH wrote: > > ... > > > Switch it in both capable() calls in the patch? Kai, is this acceptable > > > to you also? > > > > > Yes. Using CAP_SYS_ADMIN here was wrong. > > Ok, care to send a new patch that I can use for the next -stable kernel > release? > Sent in a different message. This patch does not restrict usage of SCSI_IOCTL_START_UNIT and SCSI_IOCTL_STOP_UNIT. For tapes, those mean load and unload commands. The drive status changes resulting from these commands seem to be caught by st otherwise. I will do a patch for -12rc later today or tomorrow. It may add changing some st status bits if these commands succeed but that is not -stable material.
Thanks for the review for all participants.
-- Kai - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |