lkml.org 
[lkml]   [2005]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Fw: Oops in set_spdif_output in i810_audio
From
On Sun, Apr 03, 2005 at 10:14:27PM +1000, herbert wrote:
>
> I personally don't see a reason why we should allow it to
> continue when the codec doesn't exist. What do you guys think?

Actually, anybody trying to use this driver without a codec
would've hit the same crash. Since nobody has complained
before, we should just fail the registration if there is
no codec.

Then we can get rid of all the existing codec != NULL checks.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-06 13:31    [W:0.036 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site