lkml.org 
[lkml]   [2005]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: 2.6.11.7 kernel panic on boot on AMD64
    From
    Date
    > Hmm? saved_command_Line should have enough space to add a simple string.
    > It is a 1024bytes. Unless you already have a 1k command line it should
    > be quite ok.

    init/main.c:
    char saved_command_line[COMMAND_LINE_SIZE];

    inclide/asm-x86-64/setup.h:
    #define COMMAND_LINE_SIZE 256

    Rubens command line is a total of 251 chars, adding "console=tty0" will
    exceed it.

    > Why do you think it is bogus?
    >

    I thought that saved_command_line on x64 was like the other archs, an
    untouched copy and it wouldn't have made sense to apply another string
    to it then, but I was wrong as it is the working line.

    I still don't understand why console=tty0 is to be appended however.

    > > This is bogus appending stuff to the saved_command_line and at the same
    > > time in Rubens case it touches the late_time_init() which breakes havoc.
    >
    > I dont agree with this patch.
    >
    > -Andi
    >
    > >
    > > Signed-off-by: Alexander Nyberg <alexn@telia.com>
    > >
    > > Index: linux-2.6/arch/x86_64/kernel/head64.c
    > > ===================================================================
    > > --- linux-2.6.orig/arch/x86_64/kernel/head64.c 2005-04-26 11:41:43.000000000 +0200
    > > +++ linux-2.6/arch/x86_64/kernel/head64.c 2005-04-29 11:57:46.000000000 +0200
    > > @@ -93,9 +93,6 @@
    > > #ifdef CONFIG_SMP
    > > cpu_set(0, cpu_online_map);
    > > #endif
    > > - /* default console: */
    > > - if (!strstr(saved_command_line, "console="))
    > > - strcat(saved_command_line, " console=tty0");
    > > s = strstr(saved_command_line, "earlyprintk=");
    > > if (s != NULL)
    > > setup_early_printk(s);
    > >
    > >
    --
    Alexander Nyberg <alexn@telia.com>

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-29 16:52    [W:0.032 / U:1.560 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site