lkml.org 
[lkml]   [2005]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]porting lockless mce from x86_64 to i386
Andi Kleen <ak@muc.de> wrote:
>
> On Tue, Apr 26, 2005 at 01:27:30PM +0800, Yu, Luming wrote:
> >
> > Forward a patch :
>
> Some comments:
>
> The asmlinkage on x86-64 is not really needed. You can remove
> the ifdef. fastcall is fine, although it is a nop.
>
> The u64 tsc[NR CPUS] on the stack is a stack overflow with big
> NR_CPUS. I have
> a patch locally here to fix it, but you could just apply it
> anyways when you move the code. Fix is to use kmalloc here.
>

OK, thanks. Luming, could you please reissue the second patch, including
the above fixes as well as the two warning fixes which we discussed?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-27 20:45    [W:0.037 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site