Messages in this thread | | | Date | Mon, 25 Apr 2005 23:44:51 -0700 | From | Greg KH <> | Subject | Re: [linux-usb-devel] Re: [PATCH] PCI: Add pci shutdown ability |
| |
On Tue, Apr 26, 2005 at 02:33:28AM -0400, Adam Belay wrote: > On Tue, Apr 26, 2005 at 01:39:20PM +1000, Benjamin Herrenschmidt wrote: > > > > > I believe it should just do suspend(PMSG_SUSPEND) before system > > > shutdown. If you think distintion between shutdown and suspend is > > > important (I am not 100% convinced it is), we can just add flag > > > saying "this is system shutdown". > > > > > > Actually this patch should be in the queue somewhere... We had it in > > > suse trees for a long time, and IMO it can solve problem easily. > > > > I think we probably want a distinct state for shutdown ... > > Yes, it's possible we do. I'm not sure what every platform requires. The > question is should we make this change to pm_message_t in the short term? > "->shutdown", even though incorrect, seems to fill this role. > > Greg, have you seen shutdown methods doing anything special other than > standard "->suspend" stuff?
Don't know, never looked. Try looking at the system and platform drivers, I think those are the only ones that have that callback hooked up right now.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |