lkml.org 
[lkml]   [2005]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.4.31-pre1] x86_64 breakage on UP_IOAPIC
Tiny, trivial, pedantic whitespace nit : 

On Tue, 26 Apr 2005, Mikael Pettersson wrote:

> The
>
> o x86_64: Resend lost APIC IRQs on Uniprocessor too
>
> change in 2.4.31-pre1 causes linkage errors: on UP_IOAPIC systems it
> creates references to send_IPI_self() which is only defined on SMP.
>
> The patch below reverts this change.
>
> Alternatively, x86_64 could implement a send_IPI_self() fallback for !SMP,
> just like i386 does.
>
> /Mikael
>
> --- linux-2.4.31-pre1/include/asm-x86_64/hw_irq.h.~1~ 2005-04-26 20:57:43.000000000 +0200
> +++ linux-2.4.31-pre1/include/asm-x86_64/hw_irq.h 2005-04-26 21:09:31.000000000 +0200
> @@ -156,7 +156,7 @@ static inline void x86_do_profile (unsig
> atomic_inc((atomic_t *)&prof_buffer[eip]);
> }
>
> -#ifdef CONFIG_X86_IO_APIC
> +#ifdef CONFIG_SMP /*more of this file should probably be ifdefed SMP */
^^^
Space here?


--
Jesper

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-27 00:20    [W:0.033 / U:4.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site