lkml.org 
[lkml]   [2005]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [1/1] connector/CBUS: new messaging subsystem. Revision number next.
    On 4/26/05, Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:
    >
    > --- orig/drivers/connector/connector.c
    > +++ mod/drivers/connector/connector.c
    > @@ -151,8 +151,8 @@
    > __cbq->ddata = data;
    > __cbq->destruct_data = destruct_data;
    >
    > - queue_work(dev->cbdev->cn_queue, &__cbq->work);
    > - found = 1;
    > + if (queue_work(dev->cbdev->cn_queue, &__cbq->work))
    > + found = 1;
    > break;

    What does it help exactly? By the time you checked result of
    queue_work you have already corrupted work structure wuth the new data
    (and probably destructor).

    Also, where is the rest of the code? Should we notify caller that
    cn_netlink_send has dropped the message? And how do we do that?

    --
    Dmitry
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-26 19:43    [W:0.020 / U:32.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site