lkml.org 
[lkml]   [2005]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Don't oops when unregistering unknown kprobes
> @@ -107,6 +107,13 @@ rm_kprobe:
> void unregister_kprobe(struct kprobe *p)
> {
> unsigned long flags;
> +
> + if (!get_kprobe(p)) {
> + printk(KERN_WARNING "Warning: Attempt to unregister "
> + "unknown kprobe (addr:0x%lx)\n",
> + (unsigned long) p);
> + return;
> + }

This is wrong. You should call get_kprobe() with spin_lock().


-Prasanna

--

Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<prasanna@in.ibm.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-26 18:43    [from the cache]
©2003-2011 Jasper Spaans