Messages in this thread | | | Date | Mon, 25 Apr 2005 23:06:31 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] PCI: Add pci shutdown ability |
| |
Hi!
> > > Well it seems that people are starting to want to hook the reboot > > > notifier, or the device shutdown facility in order to properly shutdown > > > pci drivers to make kexec work nicer. > > > > > > So here's a patch for the PCI core that allows pci drivers to now just > > > add a "shutdown" notifier function that will be called when the system > > > is being shutdown. It happens just after the reboot notifier happens, > > > and it should happen in the proper device tree order, so everyone should > > > be happy. > > > > > > Any objections to this patch? > > > > Yes. > > > > I believe it should just do suspend(PMSG_SUSPEND) before system > > shutdown. If you think distintion between shutdown and suspend is > > important (I am not 100% convinced it is), we can just add flag > > saying "this is system shutdown". > > So if I understand this correctly, you'd like to manually turn off devices > during a power off. I believe the ACPI spec recommends this for S4 (but also > to leave on wake devices), but not necessarily S5. Still it may be a good > idea. Comments?
It is neccessary for some machines (interrupt controller) or machine will not power down...
> > Actually this patch should be in the queue somewhere... We had it in > > suse trees for a long time, and IMO it can solve problem easily. > > Yeah, that's what I had in mind when I mentioned PMSG_FREEZE. It seems > to replace "shutdown" in many ways, is this correct?
Yes. (Actually I'm not sure if PMSG_FREEZE or PMSG_SUSPEND is right thing to do for suspend.) Pavel -- Boycott Kodak -- for their patent abuse against Java. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |