Messages in this thread | | | Date | Mon, 25 Apr 2005 15:23:09 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] PCI: Add pci shutdown ability |
| |
Greg KH wrote: > Well it seems that people are starting to want to hook the reboot > notifier, or the device shutdown facility in order to properly shutdown > pci drivers to make kexec work nicer. > > So here's a patch for the PCI core that allows pci drivers to now just > add a "shutdown" notifier function that will be called when the system > is being shutdown. It happens just after the reboot notifier happens, > and it should happen in the proper device tree order, so everyone should > be happy. > > Any objections to this patch?
Traditionally the proper place -has- been * the reboot notifier * the ->remove hook (hot unplug, and module remove)
which covers all the cases.
Add a ->shutdown hook is more of a hack. If you want to introduce this facility in a systematic way, introduce a 'kexec reboot' option which walks the device tree and shuts down hardware.
->shutdown is just a piecemeal, uncoordinated effort (uncoordinated in the sense that driver shutdowns occur in an undefined order).
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |