lkml.org 
[lkml]   [2005]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration
From
Date
"Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>" <7eggert@gmx.de> writes:

> Ed L Cashin <ecashin@coraid.com> wrote:
>
>> +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.000000000 -0400
>
>> + When the aoe driver is a module, use
>
> Is there any reason for this inconsistent behaviour?

Yes, the /sys/module/aoe area is only present when the aoe driver is a
module. It would be nicer if there were a sysfs area where I could
put this file regardless of whether the driver is a module or built
into the kernel.

I could probably create one, but I got the file in
/sys/module/aoe/parameters for free when I used module_param_string.

>> + /sys/module/aoe/parameters/aoe_iflist instead of
> ^^^
>
> Why does the module name need to be part of the attribute?
> That's redundant. That's redundant.

Yes. That's true. Redundancy isn't always bad, though, and using the
"aoe_" prefix lets the kernel parameter for the built-in aoe driver be
the same as the parameter for the modular driver.

--
Ed L Cashin <ecashin@coraid.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-21 15:45    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site