lkml.org 
[lkml]   [2005]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH] timers fixes/improvements
    Oleg Nesterov <oleg@tv-sign.ru> wrote:
    >
    > +void fastcall init_timer(struct timer_list *timer)
    > +{
    > + timer->entry.next = NULL;
    > + timer->_base = &per_cpu(tvec_bases,
    > + __smp_processor_id()).t_base;
    > + timer->magic = TIMER_MAGIC;
    > +}

    __smp_processor_id() is not implemented on all architectures. I'll switch
    this to _smp_processor_id().

    The smp_processor_id() stuff is all rather a twisty maze (looks at Ingo).

    It's a rather odd thing which you're doing there. Why does a
    not-yet-scheduled timer need a ->_base?


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-06 13:31    [W:0.020 / U:60.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site