lkml.org 
[lkml]   [2005]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH scsi-misc-2.6 02/04] scsi: remove spurious if tests from scsi_eh_{times_out|done}
    Date
    02_scsi_timer_eh_timer_remove_spurious_if.patch

    If tests which check if eh_action isn't NULL in both functions
    are always true. Remove the if's.

    Signed-off-by: Tejun Heo <htejun@gmail.com>

    scsi_error.c | 6 ++----
    1 files changed, 2 insertions(+), 4 deletions(-)

    Index: scsi-reqfn-export/drivers/scsi/scsi_error.c
    ===================================================================
    --- scsi-reqfn-export.orig/drivers/scsi/scsi_error.c 2005-04-19 23:30:57.000000000 +0900
    +++ scsi-reqfn-export/drivers/scsi/scsi_error.c 2005-04-19 23:30:58.000000000 +0900
    @@ -436,8 +436,7 @@ static void scsi_eh_times_out(unsigned l
    SCSI_LOG_ERROR_RECOVERY(3, printk("%s: scmd:%p\n", __FUNCTION__,
    scmd));

    - if (scmd->device->host->eh_action)
    - up(scmd->device->host->eh_action);
    + up(scmd->device->host->eh_action);
    }

    /**
    @@ -461,8 +460,7 @@ static void scsi_eh_done(struct scsi_cmn
    SCSI_LOG_ERROR_RECOVERY(3, printk("%s scmd: %p result: %x\n",
    __FUNCTION__, scmd, scmd->result));

    - if (scmd->device->host->eh_action)
    - up(scmd->device->host->eh_action);
    + up(scmd->device->host->eh_action);
    }
    }

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-19 16:50    [W:0.025 / U:0.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site