Messages in this thread |  | | | Date | Tue, 19 Apr 2005 15:46:42 +0900 (JST) | | Subject | Re: [PATCH] introduce generic 64bit rotations and i386 asm optimized version | | From | YOSHIFUJI Hideaki / 吉藤英明 <> |
| |
In article <200504190918.10279.vda@port.imtp.ilyichevsk.odessa.ua> (at Tue, 19 Apr 2005 09:18:10 +0300), Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> says:
> diff -urpN 2.6.12-rc2.1.be/include/linux/bitops.h 2.6.12-rc2.2.ror/include/linux/bitops.h > --- 2.6.12-rc2.1.be/include/linux/bitops.h Mon Apr 18 22:55:10 2005 > +++ 2.6.12-rc2.2.ror/include/linux/bitops.h Tue Apr 19 00:25:28 2005 > @@ -41,7 +41,7 @@ static inline int generic_ffs(int x) > * fls: find last bit set. > */ > > -static __inline__ int generic_fls(int x) > +static inline int generic_fls(int x) > { > int r = 32; > > @@ -76,7 +76,7 @@ static __inline__ int generic_fls(int x) > */ > #include <asm/bitops.h> > > -static __inline__ int get_bitmask_order(unsigned int count) > +static inline int get_bitmask_order(unsigned int count) > { > int order; >
Please keep using __inline__, not inline.
> +#ifndef ARCH_HAS_ROL64 > +static inline __u64 rol64(__u64 word, unsigned int shift) > +{ > + return (word << shift) | (word >> (64 - shift)); > +} > +#endif : > +#ifndef ARCH_HAS_ROR64 > +static inline __u64 ror64(__u64 word, unsigned int shift) > +{ > + return (word >> shift) | (word << (64 - shift)); > +} > +#endif > > #endif
please use __inline__, in header files.
-- Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org> Homepage: http://www.yoshifuji.org/~hideaki/ GPG FP : 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |