Messages in this thread | | | Date | Sun, 17 Apr 2005 14:58:51 -0700 | From | Greg KH <> | Subject | Re: [PATCH] tpm: Stop taking over the non-unique lpc bus PCI ID, Also timer, stack and enum fixes |
| |
On Sun, Apr 17, 2005 at 10:05:27AM +1000, Dave Airlie wrote: > > NO! DO NOT use pci_find_device(). It is broken for systems with pci > > hotplug (which means any pci system). Please use the way the driver > > currently works, that is correct. > > But its not an LPC driver, it only uses a small piece of the LPC, we > really do need some sort of bridge driver layer or something for > these, then other drivers can sit on top of that,
Then the TPM driver can provide that layer.
> The DRM still uses pci_find_device for the exact same reason, the fb > drivers take the PCI device and we have been told we can't use the > proper interface, hence one of the needs to merge fb and DRM..
Exactly.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |