lkml.org 
[lkml]   [2005]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero
    On Fri, Apr 15, 2005 at 09:21:50AM +0100, Christoph Hellwig wrote:
    > On Fri, Apr 15, 2005 at 02:31:00AM +0100, Matthew Wilcox wrote:
    > > On Fri, Apr 15, 2005 at 03:07:42AM +0200, Jesper Juhl wrote:
    > > > 'arg' is unsigned so it can never be less than zero, so testing for that
    > > > is pointless and also generates a warning when building with gcc -W. This
    > > > patch eliminates the pointless check.
    > >
    > > Didn't Linus already reject this one 6 months ago?
    >
    > I think Linux only complained if we're using some typedef that actually
    > may be signed. For fcntl that 'arg' argument is unsigned and that's hardcoded
    > in the ABI. So the check doesn't make sense at all.

    No, it was exactly this patch:
    http://www.ussg.iu.edu/hypermail/linux/kernel/0401.0/1816.html

    --
    "Next the statesmen will invent cheap lies, putting the blame upon
    the nation that is attacked, and every man will be glad of those
    conscience-soothing falsities, and will diligently study them, and refuse
    to examine any refutations of them; and thus he will by and by convince
    himself that the war is just, and will thank God for the better sleep
    he enjoys after this process of grotesque self-deception." -- Mark Twain
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-15 13:32    [W:0.020 / U:32.244 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site