[lkml]   [2005]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRE: [PATCH] kernel - I2C adaptor for ColdFire 5282 CPU
    OK, hope this patch can satisfy everyone :-)

    The following is the diffstat of the enclosed patch file:

    drivers/i2c/busses/Kconfig | 10
    drivers/i2c/busses/Makefile | 1
    drivers/i2c/busses/i2c-mcf5282.c | 414
    drivers/i2c/busses/i2c-mcf5282.h | 46 ++++
    include/asm-m68knommu/m528xsim.h | 42 +++
    5 files changed, 513 insertions(+)

    I did:

    a) remove all trailing spaces in the files
    b) re-align the switch statement
    c) change a return statement
    d) change some white space intents to TABs
    e) insert a break for the I2C_SMBUS_PROC_CALL, thanks for spotting it
    f) fix the mcf5282lite wording in Kconfig

    I did not:

    g) use the ioremap. This is because Coldfire is a CPU without MMU and
    there is no difference between virtual and physical memory. In fact, the
    ioremap routine in the m68knommu is simply a stub routine that returns
    the input address argument for compatibility reason. Also, all other
    Coldfire CPU include files such as the m5307sim.h uses the volatile
    declaration method.
    So, I hope this is acceptable to the Linux kernel maintainers

    Please let me know if there is any question.


    -----Original Message-----
    From: Greg KH []
    Sent: April 11, 2005 4:03 PM
    To: Derek Cheung
    Cc: 'Randy.Dunlap'; 'Andrew Morton';
    Subject: Re: [PATCH] kernel - I2C adaptor for ColdFire 5282 CPU

    On Sun, Apr 10, 2005 at 12:47:42PM -0400, Derek Cheung wrote:
    > Enclosed please find the updated patch that incorporates changes for
    > the comments I received.

    You did not cc: the sensors mailing list, nor fix all of the coding
    style issues.

    > The volatile declaration in the m528xsim.h is needed because the
    > declaration refers to the ColdFire 5282 register mapping.

    Shouldn't you be calling ioremap, and not directly accessing a specific
    register location through a pointer? That's how all other arches do


    greg k-h
    [unhandled content-type:application/octet-stream]
     \ /
      Last update: 2005-04-14 03:19    [W:0.022 / U:93.696 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site