lkml.org 
[lkml]   [2005]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6 patch] drivers/block/ll_rw_blk.c: possible cleanups
    On Sun, Apr 10 2005, Adrian Bunk wrote:
    > This patch contains the following possible cleanups:
    > - make needlessly global code static
    > - remove the following unused global functions:
    > - blkdev_scsi_issue_flush_fn

    Kill the function completely, it is not used anymore.

    > - __blk_attempt_remerge

    Normally I would say leave that since it's part of the API, but lets
    just kill it. I don't envision any further users of the remerging
    attempts.

    > - remove the following unused EXPORT_SYMBOL's:
    > - blk_phys_contig_segment
    > - blk_hw_contig_segment
    > - blkdev_scsi_issue_flush_fn
    > - __blk_attempt_remerge
    >
    > Please review which of these changes make sense.

    Looks fine to me, thanks. Can you send a new patch that kills
    blkdev_scsi_issue_flush_fn()?

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-11 08:19    [W:0.045 / U:0.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site